From 5799884862363ef1299d2818d9bbc191cfd19413 Mon Sep 17 00:00:00 2001 From: bokuweb Date: Fri, 9 Feb 2024 19:23:51 +0900 Subject: [PATCH] fix: some clippy (#677) --- .../src/documents/elements/instr_hyperlink.rs | 2 +- docx-core/src/documents/elements/instr_tc.rs | 4 ++-- docx-core/src/documents/elements/instr_toc.rs | 18 +++++++++--------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docx-core/src/documents/elements/instr_hyperlink.rs b/docx-core/src/documents/elements/instr_hyperlink.rs index 242ec90..9faf170 100644 --- a/docx-core/src/documents/elements/instr_hyperlink.rs +++ b/docx-core/src/documents/elements/instr_hyperlink.rs @@ -54,7 +54,7 @@ impl std::str::FromStr for InstrHyperlink { let _ = s.next(); } _ => { - target = i.replace(""", "").replace("\"", "").to_string(); + target = i.replace(""", "").replace('\"', "").to_string(); } } } else { diff --git a/docx-core/src/documents/elements/instr_tc.rs b/docx-core/src/documents/elements/instr_tc.rs index 5583fdf..d1bfcdd 100644 --- a/docx-core/src/documents/elements/instr_tc.rs +++ b/docx-core/src/documents/elements/instr_tc.rs @@ -59,7 +59,7 @@ impl BuildXML for InstrTC { } fn parse_level(i: &str) -> Option { - let r = i.replace(""", "").replace("\"", ""); + let r = i.replace(""", "").replace('\"', ""); if let Ok(l) = usize::from_str(&r) { return Some(l); } @@ -78,7 +78,7 @@ impl std::str::FromStr for InstrTC { match i { "\\f" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); tc = tc.item_type_identifier(r); } } diff --git a/docx-core/src/documents/elements/instr_toc.rs b/docx-core/src/documents/elements/instr_toc.rs index e9617b3..c0beb11 100644 --- a/docx-core/src/documents/elements/instr_toc.rs +++ b/docx-core/src/documents/elements/instr_toc.rs @@ -253,7 +253,7 @@ impl BuildXML for InstrToC { } fn parse_level_range(i: &str) -> Option<(usize, usize)> { - let r = i.replace(""", "").replace("\"", ""); + let r = i.replace(""", "").replace('\"', ""); let r: Vec<&str> = r.split('-').collect(); if let Some(s) = r.get(0) { if let Ok(s) = usize::from_str(s) { @@ -278,31 +278,31 @@ impl std::str::FromStr for InstrToC { match i { "\\a" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); toc = toc.caption_label(r); } } "\\b" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); toc = toc.entry_bookmark_name(r); } } "\\c" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); toc = toc.caption_label_including_numbers(r); } } "\\d" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); toc = toc.sequence_and_page_numbers_separator(r); } } "\\f" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); toc = toc.tc_field_identifier(r); } } @@ -330,19 +330,19 @@ impl std::str::FromStr for InstrToC { } "\\p" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); toc = toc.entry_and_page_number_separator(r); } } "\\s" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); toc = toc.seq_field_identifier_for_prefix(r); } } "\\t" => { if let Some(r) = s.next() { - let r = r.replace(""", "").replace("\"", ""); + let r = r.replace(""", "").replace('\"', ""); let mut r = r.split(','); loop { if let Some(style) = r.next() {